search

arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API
https://payments.rs
Apache License 2.0
445 stars 128 forks source link

Corrected CancelSubscription fields for current Stripe API version. #411

Closed nryanl closed 7 months ago

nryanl commented 1 year ago

Same as #402. Accidentally closed. Sorry!

Corrected CancelSubscription fields for current Stripe API version.

A fix for #394

https://stripe.com/docs/api/subscriptions/cancel

According to the current Stripe API in the link above, there is no "reason" field within cancellation_details any longer. This also aligns with my testing where it did not recognize the parameter. Consider removing this struct in future versions. For now, users can leave this as None.

Checklist

WoodyWoodster commented 1 year ago

Should we include a fix for https://github.com/arlyon/async-stripe/issues/419 in this since you are doing work around at_period_end already?

arlyon commented 1 year ago

I don't mind merging this now and opening a new PR. Thanks! We are waiting on a fix in #426 to fix CI and then I will ask you to rebase.