arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API
https://payments.rs
Apache License 2.0
445 stars 128 forks source link

Added Search API functionality #414

Closed hzargar2 closed 10 months ago

hzargar2 commented 1 year ago

Summary

Added Stripe's Search API functionality for charge, customer, invoice, payment_intent, price, product, and subscription.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #414 (b54a4e5) into master (3dd6fec) will decrease coverage by 0.03%. Report is 11 commits behind head on master. The diff coverage is 0.00%.

:exclamation: Current head b54a4e5 differs from pull request most recent head 0298de5. Consider uploading reports for the commit 0298de5 to get more accurate results

@@            Coverage Diff            @@
##           master    #414      +/-   ##
=========================================
- Coverage    5.85%   5.82%   -0.03%     
=========================================
  Files         146     146              
  Lines       22573   22671      +98     
=========================================
  Hits         1321    1321              
- Misses      21252   21350      +98     
Files Changed Coverage Δ
src/params.rs 58.85% <0.00%> (-20.35%) :arrow_down:
src/resources/charge_ext.rs 0.00% <0.00%> (ø)
src/resources/customer_ext.rs 0.00% <0.00%> (ø)
src/resources/invoice_ext.rs 0.00% <0.00%> (ø)
src/resources/payment_intent_ext.rs 0.00% <0.00%> (ø)
src/resources/subscription_ext.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

arlyon commented 1 year ago

Thanks for this, going to make some time to review this properly very soon :)

arlyon commented 1 year ago

could you please mark one of the commits with the feat: prefix and I will merge after you address the comment

hzargar2 commented 1 year ago

@arlyon Hi, is there a issue with the CI jobs? Some checks seem to fail but the error is not precise. I don't think the error is from my code. Says async-stripe fails to compile but it compiles locally on my machine.

arlyon commented 1 year ago

Hi! We have in fact been having issues due to cargo-llvm-cov. I have ripped it out. Please rebase for me and I'll have another look.

hzargar2 commented 1 year ago

Hi! We have in fact been having issues due to cargo-llvm-cov. I have ripped it out. Please rebase for me and I'll have another look.

@arlyon I've rebased it however, I am not sure if I did it correctly as I am also not very familiar with git. Please let me if there are any issues. Thanks.

hzargar2 commented 11 months ago

@arlyon I know you might be busy but is there any update on this? I see it says there is a change requested above which I implemented. Is there anything else you need form my end? Thanks.

arlyon commented 10 months ago

Merged, thanks for taking the time, and your patience :)