Closed ahartel closed 1 year ago
Hope we picked the right rust version. Was there another specific reason for pinning time-core instead of only pinning the rust version?
Thank you for opening this PR, I am also running into this issue.
@arlyon Hi, is there any chance you could have a look at this PR? The current state of events (with pinned time) is causing issues in my projects.
Hey @arlyon any chance you can have a look at this one? This blocks us from updating our dependencies. Thanks!
Hello! Thanks for this and sorry for the late reply, I have been drowning in notifs (130 and counting...). Our MSRV is actually 1.65 now so we can remove the requirement. I will merge this ASAP once you bump the version in the toml file. I believe time-core
bumped their msrv to 1.63 a few versions back and we probably should have removed this restriction when we bumped but it's easy to lose track of these things. Sorry for the pain! Closes #395
@ahartel please ping me directly when this is done to shortcut the queue :skier:
Closing in favour of the other pr (which will be merged shortly!)
Summary
We ran into issue closes #395 and propose the following solution
Checklist
cargo make fmt