arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API

https://payments.rs

Apache License 2.0

436 stars 127 forks source link

Pin rust version to 1.65 instead of pinning time-core #426

Closed timsueberkrueb closed 12 months ago

timsueberkrueb commented 1 year ago

Summary

See https://github.com/arlyon/async-stripe/pull/421#issuecomment-1683880259

Checklist

[x] ran cargo make fmt
[x] using conventional commits to hightlight user-facing fixes and features

arlyon commented 1 year ago

looks like time now needs 1.67.0 so lets just bump our msrv to that while we are at it. change the version in cargo.toml and in the .github worflows (for CI)

timsueberkrueb commented 1 year ago

@arlyon done, thank you!

arlyon commented 1 year ago

Running CI again, TY

timsueberkrueb commented 1 year ago

@arlyon the CI failing is an unrelated issue I assume?

timsueberkrueb commented 1 year ago

Hey @arlyon, any update on this one? Thanks :)

timsueberkrueb commented 12 months ago

Hey @arlyon, it would be really cool if we could land this and have a new crates.io release containing the fix. Thanks!

arlyon commented 12 months ago

Hi there, tests aren't passing and it seems that rustc is segfaulting when used with cargo-llvm-cov. I am going to rip it out, because it just adds another layer of mess.

arlyon commented 12 months ago

Fixed in this PR https://github.com/arlyon/async-stripe/pull/433

New release to crates coming now