Closed FSMaxB closed 11 months ago
I really don't think there's anything I can/should do about the verify-codegen
test failure ...
I am not sure why the codegen would be causing an issue. I will merge this and solve that separately, TY.
Do you know what status code was failing for you?
Sadly no, because the panic message didn't contain that information. But there's some mention of cloudflare status codes here: https://github.com/http-rs/http-types/issues/507
Seems like silly behaviour on both sides. I am ok using this as a workaround. Release 0.25.2 is publishing now :)
Edit: live!
We had a panic in production because of a well known issue in
http_types
where StatusCode conversion can panic:A proper fix probably involves switching away from
http_types
entirely, but I interrupted my initial attempt because that requires changes all over the code base (replacingRequest
,Method
,Url
andBody
types).Therefore I'm submitting this quick fix which just avoids the code path with the
unwrap
.Checklist
cargo make fmt