arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API
https://payments.rs
Apache License 2.0
418 stars 122 forks source link

fix(codegen): stripe "terminal" is not an object, but its subpaths are #475

Closed dgramop closed 5 months ago

dgramop commented 6 months ago

Was trying to generate a terminal connection token, but codegen incorrectly uses terminal as an object (instead of as a resource), leading to requests for terminal objects (like terminal.connection_token) being mislabeled in the map, and those objects not being found when it came time to generate impl's for their requests

Summary

Checklist

dgramop commented 6 months ago

Note: I didn't run openapi-install before this commit, is that something I should take care of? Not sure what prefer w/r to keeping history clean. Lmk if you'd like me to to run it

arlyon commented 5 months ago

Hey man, I just ran CI, will report back in a little bit. Thanks for taking the time!

arlyon commented 5 months ago

Merged! Doing a release today