arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API

https://payments.rs

Apache License 2.0

418 stars 122 forks source link

fix: rename serde for Self_ to "self" for direct deserialization of JSON #502

Closed lthiery closed 5 months ago

lthiery commented 5 months ago

Summary

This renames the serde of the Self_ field to be self. This allows the structs to be directly deserialized from JSON.

Checklist

[x] ran cargo make fmt
[x] using conventional commits to hightlight user-facing fixes and features

augustoccesar commented 5 months ago

Changes to files under the generated folder would be overwritten next time that the schema is updated. There is a PR already to do this change on the codegen that will solve this issue (https://github.com/arlyon/async-stripe/pull/490).

arlyon commented 5 months ago

Closing in favour of #490 which is merged now.

lthiery commented 5 months ago

Oh great, thanks! And thanks for pointing out the other PR - good to understand a little better how the codegen works.