arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API

https://payments.rs

Apache License 2.0

418 stars 122 forks source link

fix: correctly generate types for optional lists #503

Closed arlyon closed 4 months ago

arlyon commented 5 months ago

Summary

We were special casing optional lists, rather than following the spec. This code path has been around forever and has likely been invalid. This is a breaking change.

Closes https://github.com/arlyon/async-stripe/issues/456 and https://github.com/arlyon/async-stripe/issues/496

Checklist

[x] ran cargo make fmt
[x] using conventional commits to hightlight user-facing fixes and features

extrawurst commented 4 months ago

amazing! thank you! Planning a release with it?

edmiester777 commented 4 months ago

Was looking around a lot for this PR. Will be useful when released!