arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API
https://payments.rs
Apache License 2.0
453 stars 130 forks source link

Inconsistent latest version in different places #521

Closed lgarron closed 5 months ago

lgarron commented 6 months ago

Describe the bug

https://www.payments.rs/ has a big button labelled "Documentation".

Screenshot 2024-03-19 at 17 44 14

It links to https://docs.rs/async-stripe/0.34.2/stripe , which says "The requested version does not exist"

Screenshot 2024-03-19 at 17 44 31

https://docs.rs/async-stripe/latest/stripe/ shows the latest version as v0.34.1

Screenshot 2024-03-19 at 17 44 50

The latest release shown on the GitHub project page is v0.18.3, because that's the latest version marked at https://github.com/arlyon/async-stripe/releases

Screenshot 2024-03-19 at 17 45 15

Also, the top of https://www.payments.rs/ contains a link that implies that it links to the tag v0.34.2, but that link actually just goes to https://github.com/arlyon/async-stripe (which only displays v0.18.3 as the latest GitHub release, as mentioned above).

Screenshot 2024-03-19 at 17 46 32

This… does not inspire confidence for someone looking at this library for the first time. I'd recommend:

To Reproduce

See above.

Expected behavior

See above.

Code snippets

No response

OS

N/A

Rust version

N/A

Library version

N/a

API version

N/A

Additional context

No response

arlyon commented 6 months ago

The automated release pipeline has been borked for a while sadly so I have been having to publish releases to GitHub manually. The latest version on the website is the latest git tag but not all tags have a github release so it's all a little messy. We are going to have to rework a decent chunk of the CI / release pipeline for the next branch once it is ready for primetime so I have been putting off fixing it since it'll be soon obsolete.

Apologies for the confusion. Also on my list is updating the readme alongside this stuff.

Once we figure out why semantic release cargo is failing this should all resolve itself and change logs, tags, cargo releases, and GitHub releases should remain synced up.

jwiesler commented 5 months ago

Semantic release is fixed.