search

arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API
https://payments.rs
Apache License 2.0
453 stars 130 forks source link

Dependency breaks CI #532

Closed ferrohd closed 5 months ago

ferrohd commented 5 months ago

Describe the bug

The MSRV in CI is pinned to 1.68.0 but the dependency lalrpop requires at least 1.70.0 to build, failing the test matrix and blocking new PR like #518 #527 #524.

To Reproduce

Trigger the CI by pushing to master or open a new PR.

Expected behavior

A not failing CI

Code snippets

No response

OS

linux

Rust version

1.68.0

Library version

latest

API version

latest

Additional context

Solution 1

Bump the MSRV in CI to 1.70.0. This doesn't break the 3-versions-behind-latest rule, being stable at 1.77.0

Solution 2

Pin the lalrpop dependency to 0.20.0 which is the latest with MSRV <= 1.68.0

arlyon commented 5 months ago

Thanks for the report. Got a PR that I will sort out tonight