arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API

https://payments.rs

Apache License 2.0

414 stars 121 forks source link

possible suggestions, based on a fix to our app #555

Open Connoropolous opened 1 month ago

Connoropolous commented 1 month ago

Summary

@arlyon I'm not opening this PR to suggest you merge these changes, as they might not work for everyone, and I don't know all that much about the library, but I will say that this source property appears to be deprecated, and that not having it there caused a bug in the case of my application, when a Charge with a source that came from a connected app (Gumroad) came through the pipes. Feel free to close after checking it out?

Checklist

[ ] ran cargo make fmt
[ ] using conventional commits to hightlight user-facing fixes and features

Connoropolous commented 1 month ago

cool! I just added another fix, after debugging, which was PriceId can include subscription_plan.

I'm curious, what was the big pull for building async-stripe? Who's using it? Also curious, what kind of timeframe is next branch progressing on?

seanpianka commented 1 month ago

cool! I just added another fix, after debugging, which was PriceId can include subscription_plan.

I'm curious, what was the big pull for building async-stripe? Who's using it? Also curious, what kind of timeframe is next branch progressing on?

async-stripe is a fork from the original project stripe-rs and is currently the only maintained Stripe client bindings for Rust, as Stripe does not officially support the language. All the same kinds of projects and organizations (in other language communities) which use Stripe are the kinds of users async-stripe sees!

Connoropolous commented 1 month ago

cool. With the state of the repo and the next dev branch, is there value in trying to get my schema patches merged?