search

arlyon / veining

Introduces a new enchantment: Veining. Pickaxes with this enchantment will crumble entire veins at once.
https://minecraft.curseforge.com/projects/veining
Other
5 stars 2 forks source link

Stall #20

Open bookerthegeek opened 5 years ago

bookerthegeek commented 5 years ago

Heyo!

Love the mod, have a question, and an Issue. Issue first.

  1. Using this mod my game stalled and had to be forced killed as it would never recover.
  2. Can we get a setting to only allow multiple ore types if they share an ore dictionary entry?

Version Information

Report Information

Game froze and never recovered.

Steps to Reproduce

  1. Set settings to have on block spacing between ores
  2. And change it to effect multiple types of ores.
  3. Mine a large group of ores I suppose.

Forge Log

HERE is the console log.

Log

HERE is the stall report.

arlyon commented 5 years ago

Hey thanks for the kind words.

For the first part, the algorithm can freeze if there is a very large number of nodes (tens of thousands) to mine. I am considering moving toward an algorithm that would space the block breaks over multiple ticks which would mean blocks would not break instantly (and so massive breakages would not freeze the game) and the calculation could run in the background while the game continues. I've started work on this but haven't found the time to finish it.

As for the 2nd one: that is something I never considered, but that I am keen to include. I'll mark this as a feature request.

bookerthegeek commented 5 years ago

Thank you. :) I look forward to you next release. (No rush, take your time. Love the mod.)