armackey / nativescript-twilio-video

A Nativescript video chat plugin.
12 stars 8 forks source link

Way to select codec ? #3

Open mouf13 opened 6 years ago

mouf13 commented 6 years ago

HI,

On Web, to make Twilio work both on ios and chrome, we need to change the preferred codec option. Could you add this this ? Here an example for web :

connect(token, { name: 'room', preferredVideoCodecs: [ { codec: 'VP8', simulcast: true } // this._codec === 'VP8' ? { codec: 'VP8', simulcast: true } : { codec: 'H264' } ] })

Thanks and thx a lot for your plugin !

praveshkhatana commented 5 years ago

Hey @mouf13,

Did you find solution?

armackey commented 5 years ago

@mouf13 I'll have to take a look over the weekend if I have free time.

mouf13 commented 5 years ago

Hi @armackey & @praveshkhatana, The options were commented in android/twilio-video & ios/twilio-video. I also updated the Twilio SDKs. Unfortunately i can't make the video works between web and Android. It's ok with IOS. I can share my updates if need.

praveshkhatana commented 5 years ago

@mouf13, yes i also found the same issue with Android devices, ios one is working fine. I think it's related to codec or view element.

praveshkhatana commented 5 years ago

please share your updates

mouf13 commented 5 years ago

@praveshkhatana https://we.tl/t-12Z5ebNGWh

praveshkhatana commented 5 years ago

thanks @mouf13 :)

you can have a look at mine, if you need camera flip option https://github.com/praveshkhatana/nativescript-twilio-video

mouf13 commented 5 years ago

Thx @praveshkhatana i will

praveshkhatana commented 5 years ago

Hey @mouf13

Did you find a working solution for Android? Video feed is not working even in between two android devices. :(

mouf13 commented 5 years ago

hi @praveshkhatana sorry for my late answer, we finally switch to reactnative, works well on ios&android.

armackey commented 5 years ago

doesn't look like there's an issue here but a request.

armackey commented 5 years ago

Will implement codecs soon.