search

armadaproject / armada-operator

Apache License 2.0
12 stars 10 forks source link

chore: massive redo of Operator #295

Closed dejanzele closed 9 months ago

dejanzele commented 9 months ago

Fixes https://github.com/G-Research/gr-oss/issues/478

github-advanced-security[bot] commented 9 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (bda0e29) 84.19% compared to head (cce34f8) 84.19%.

Files Patch % Lines
...ternal/controller/install/binoculars_controller.go 78.08% 10 Missing and 6 partials :warning:
internal/controller/install/executor_controller.go 59.25% 6 Missing and 5 partials :warning:
...rnal/controller/install/armadaserver_controller.go 57.89% 5 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #295 +/- ## ======================================= Coverage 84.19% 84.19% ======================================= Files 15 15 Lines 3441 3461 +20 ======================================= + Hits 2897 2914 +17 - Misses 381 383 +2 - Partials 163 164 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.