armadaproject / armada-operator

Apache License 2.0
13 stars 10 forks source link

chore: remove duplicated code and fix minor bugs #326

Closed dejanzele closed 2 months ago

dejanzele commented 2 months ago

Pull Request Template

Description

Please include a summary of the changes and the related issue (if any). Describe your changes in detail to help reviewers understand your contribution.

Fixes # (issue)

Type of change

Please select the type of change your PR introduces:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions to reproduce these tests. List any relevant details for your test configuration.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 59.68992% with 104 lines in your changes missing coverage. Please review.

Project coverage is 84.67%. Comparing base (d82cf81) to head (e249792). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/install/lookout_controller.go 45.94% 11 Missing and 9 partials :warning:
...ternal/controller/install/binoculars_controller.go 41.37% 9 Missing and 8 partials :warning:
internal/controller/install/executor_controller.go 42.85% 8 Missing and 8 partials :warning:
...nternal/controller/install/scheduler_controller.go 42.85% 6 Missing and 6 partials :warning:
...rnal/controller/install/armadaserver_controller.go 65.51% 6 Missing and 4 partials :warning:
internal/controller/install/common_helpers.go 85.93% 6 Missing and 3 partials :warning:
...controller/install/scheduleringester_controller.go 61.90% 4 Missing and 4 partials :warning:
...nal/controller/install/eventingester_controller.go 53.84% 3 Missing and 3 partials :warning:
...l/controller/install/lookoutingester_controller.go 62.50% 3 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #326 +/- ## ========================================== + Coverage 84.30% 84.67% +0.36% ========================================== Files 15 15 Lines 3467 3327 -140 ========================================== - Hits 2923 2817 -106 + Misses 381 353 -28 + Partials 163 157 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.