fix: pruning related issues - Githubissues

armadaproject / armada-operator

Apache License 2.0

13 stars 10 forks source link

fix: pruning related issues #332

Closed Sovietaced closed 1 month ago

Sovietaced commented 1 month ago

Description

Bug Fixes

Fixes an issue where the scheduler cron job would never get created due to variable shadowing
Fixes an issue where the scheduler cron job would run with an invalid command
Fixes an issue where cron job updates wouldn't get synced

Enhancements

Plumbs service accounts to cron jobs

Type of change

Please select the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code Style Update (formatting, renaming)
[ ] Refactor (code changes that do not fix a bug or add a feature)
[ ] Documentation Update
[ ] Other (please describe):

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.