search

armadsen / ORSSerialPort

Serial port library for Objective-C and Swift macOS apps
MIT License
753 stars 183 forks source link

Address Sanitizer reports use of deallocated memory in sendData: #106

Closed kirk-kerekes closed 6 years ago

kirk-kerekes commented 8 years ago

Address Sanitizer intermittently reports use of deallocated memory in sendData:, as invoked by sendNextRequest->reallySendRequest:. My guess is over-aggressive ARC activity -- the request is deleted from the requests queue, and then sent.

Ought to be OK, but there are enough async activities floating around to make me wonder.

armadsen commented 8 years ago

Hi Kirk,

Thanks very much for the report. I'll take a look at this. Either way, I'd rather not have address sanitizer complaining about anything!

On Aug 12, 2016, at 9:30 AM, kirk-kerekes notifications@github.com wrote:

Address Sanitizer intermittently reports use of deallocated memory in sendData:, as invoked by sendNextRequest->reallySendRequest:. My guess is over-aggressive ARC activity -- the request is deleted from the requests queue, and then sent.

Ought to be OK, but there are enough async activities floating around to make me wonder.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

armadsen commented 7 years ago

So far I'm unable to reproduce this in the (Objective-C) RequestResponseDemo example project included with ORSSerialPort. Running the app for a while with Address Sanitizer enabled does not result in any flagged errors. @kirk-kerekes: Are you able to provide any further information about reproducing this?

kirk-kerekes commented 7 years ago

Only that my app is likely more complicated and busier than the example app.

On Dec 12, 2016, at 1:23 PM, Andrew Madsen notifications@github.com wrote:

So far I'm unable to reproduce this in the (Objective-C) RequestResponseDemo example project included with ORSSerialPort. Running the app for a while with Address Sanitizer enabled does not result in any flagged errors. @kirk-kerekes https://github.com/kirk-kerekes: Are you able to provide any further information about reproducing this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/armadsen/ORSSerialPort/issues/106#issuecomment-266525760, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJZTy3wwrszY94NLfVtb1X0Oq3AxVcmks5rHZ8_gaJpZM4JjMo7.

armadsen commented 6 years ago

Closing this due to inability to reproduce it.