search

armadsen / ORSSerialPort

Serial port library for Objective-C and Swift macOS apps
MIT License
751 stars 183 forks source link

Change IOKitDevice case define. #165

Closed tbago closed 2 years ago

tbago commented 3 years ago

I don't know why use setIoKitDevice to set _IOKitDevice. Maybe a spell wrong, Or just design like that? So this code style confuse me a lot. So I just pull a request to show what I mean.

armadsen commented 2 years ago

tbago, thanks for this. I actually agree that in hindsight I should have capitilized things the way you suggest, but at this point, I don't think the possible side effects of such a change on end users of the framework (including forks) warrants this change.

lordAnubis commented 2 years ago

Make then both, but with a end of life for the wrong one.

On 6 Mar 2022, at 22:20, Andrew Madsen @.***> wrote:

tbago, thanks for this. I actually agree that in hindsight I should have capitilized things the way you suggest, but at this point, I don't think the possible side effects of such a change on end users of the framework (including forks) warrants this change.

— Reply to this email directly, view it on GitHub https://github.com/armadsen/ORSSerialPort/pull/165#issuecomment-1060041346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACSPAMTHFC3UE5GYXJQDKTU6UOSFANCNFSM4T4NSEVA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.