armadsen / ORSSerialPort

Serial port library for Objective-C and Swift macOS apps
MIT License
751 stars 183 forks source link

Fix Xcode 12 errors #170

Closed flemingm closed 3 years ago

flemingm commented 3 years ago

ORSSerialPort.h one extra { add in last commit in - (instancetype)initWithDevice:(io_object_t)device; Line #163

Explained: ORSSerial/ORSSerialPacketDescriptor.h file not found in issue #169

defined the following in ORSSerialPort.h

// defined missing interface to fix XCODE 12.3 errors.

armadsen commented 3 years ago

Thanks for this. Not using the framework is no longer officially supported, because it's complicated to correctly include framework headers from other framework headers while also supporting non-framework usage. I have fixed the build failure due to the extra brace on master. I'm going to close this, but I appreciate your contribution.