Pass Unrelated Props Through to the Wrapped Component

armand1m / react-with-firebase-auth

Higher-Order Component for integrating Firebase Authentication methods with a React Component through props

https://armand1m.github.io/react-with-firebase-auth/

MIT License

130 stars 31 forks source link

Pass Unrelated Props Through to the Wrapped Component #67

Closed cernockyd closed 4 years ago

cernockyd commented 4 years ago

It looks like the wrapper component does not respect convention from React docs: https://reactjs.org/docs/higher-order-components.html#convention-pass-unrelated-props-through-to-the-wrapped-component

armand1m commented 4 years ago

actually, it does: https://github.com/armand1m/react-with-firebase-auth/blob/master/src/index.tsx#L173

are you running into some issue?

cernockyd commented 4 years ago

Hello, I eventually realized that it wasn't the case so I closed the issue. I did encounter a problem but it turned out to be completely unrelated to this repo. Thank you so much for caring anyway! :-)