search

armbian / build

Armbian Linux build framework generates custom Debian or Ubuntu image for x86, aarch64, riscv64 & armhf
https://www.armbian.com
GNU General Public License v2.0
4.26k stars 2.33k forks source link

config-default.conf no longer read by default? #6374

Open matthijskooijman opened 8 months ago

matthijskooijman commented 8 months ago

What happened?

I recently upgraded my build repo from an old version, and it seems it no longer reads userpatches/config-default.conf by default when I run ./compile.sh. When I explicitly specify it with ./compile.sh default it does get read.

Maybe this is intentional and the idea is to now always specify a config name, but the docs seem to suggest (though a bit vaguely) that config-default.conf should be loaded by default:

After the first run of compile.sh a new configuration file config-example.conf and symlink config-default.conf will be created. You may edit it to your needs or create different configuration files using it as a template.

Looking at the code, it seems the config filename(s) are stored in $ARMBIAN_CONFIG_FILES, but that has no default value and values only get added from commandline arguments, so it seems the code is not even trying to load config-default.conf by default (which might make this is a documentation bug). See https://github.com/search?q=repo%3Aarmbian%2Fbuild+ARMBIAN_CONFIG_FILES&type=code

How to reproduce?

./compile.sh

Branch

main (main development branch)

On which host OS are you observing this problem?

Other

Relevant log URL

No response

Code of Conduct

github-actions[bot] commented 8 months ago

Jira ticket: AR-2099

rpardini commented 8 months ago

Yes, I've wrote some bad docs that never got merged, https://github.com/armbian/documentation/commit/ef5befb9e432c8db2625d9b21f2e27014b73a0fb?short_path=83d55c9#diff-83d55c94e1aeaa5c79c556aab6744acc2e218e79de654b376b561189fb715315

rpardini commented 8 months ago

Sorry didn't mean to close

igorpecovnik commented 8 months ago

Yes, I've wrote some bad docs that never got merged

They were few hours ago :) Following "better this half done then totally outdated" principle.

matthijskooijman commented 8 months ago

Thanks for clarifying.

I would suggest also updating this section, since I also suspect that the config-default.conf symlink is no longer created again, and also that section does not document that you can (should, by now) actually pass a config name to the compile.sh script.

rpardini commented 8 months ago

Yes, we've to review the rest of the docs, indeed.