armbian / build

Armbian Linux build framework generates custom Debian or Ubuntu image for x86, aarch64, riscv64 & armhf
https://www.armbian.com
GNU General Public License v2.0
4.24k stars 2.31k forks source link

[Bug]: syntax error in /etc/update-motd.d/30-armbian-sysinfo #7234

Closed CT1IQI closed 1 month ago

CT1IQI commented 1 month ago

What happened?

30-armbian-sysinfo produces system info upon login, but the function display() can receiver as parameter $2 a floating point number from the traffic reporting function. Bash only knows integer arithmetic. In line if [[ -n "$2" && "$2" -gt "0" && (( "${2%.}" -ge "$4" )) ]]; then The '$2 -gt' throws an error. The second -ge has been corrected for not having the dot decimal part of the string. This should also be done for the first: if [[ -n "$2" && "${2%.}" -gt "0" && (( "${2%.*}" -ge "$4" )) ]]; then

second problem: hard coded in line 19 is the interface name eth0. But Armbian changed this to end0.

How to reproduce?

run the script

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Ubuntu 24.04 Noble

Are you building on Windows WSL2?

Relevant log URL

No response

Code of Conduct

github-actions[bot] commented 1 month ago

Jira ticket: AR-2492

igorpecovnik commented 1 month ago

hard coded in line 19 is the interface name eth0. But Armbian changed this to end0.

This is read from /etc/default/armbian-motd where we have:

PRIMARY_INTERFACE="$(ip route | grep '^default' | sed "s/.*dev //" | cut -d" " -f1 | head -1)"

Fixing is coming in a minute.

SuperKali commented 1 month ago

@CT1IQI should be fixed with #7247 can you retry with compile a newer version?

SuperKali commented 1 month ago

The issue has been resolved by Igor, i will close this issue