armbian / build

Armbian Linux build framework generates custom Debian or Ubuntu image for x86, aarch64, riscv64 & armhf
https://www.armbian.com
GNU General Public License v2.0
4.26k stars 2.33k forks source link

[Feature Request]: Luckfox Core3566 ugly support or to not support at all #7295

Closed buldo closed 1 month ago

buldo commented 1 month ago

Which feature would you like to have?

Hello, there is RK3566 compute module Luckfox Core3566. As I understand it co-branded in some way with Waveshare.
Manufacturer provides very bad sdk based on old kernel.

What I did:

This allows me to get working image for Luckfox Core3566( my board has no wifi module and emmc).

But patch soooo ugly so I don't know to do or not PR

armbian-core3566.patch

Can someone provide feedback about my patch? P.S. I have no resources to refactor or support in long term

Funding

github-actions[bot] commented 1 month ago

Jira ticket: AR-2500

EvilOlaf commented 1 month ago

The dts files should go into armbian/linux-rockchip like this: https://github.com/armbian/linux-rockchip/pull/245 and the rest into the build repo here. Would be two individual PRs.

buldo commented 1 month ago

@EvilOlaf what about u-boot DTS?
In my branch radxa u-boot used and patched

EvilOlaf commented 1 month ago

I think here: https://github.com/armbian/build/tree/main/patch/u-boot/legacy

ceccocats commented 1 month ago

Hi @buldo I have a Core3566 (with wifi and emmc), i can help you testing.

buldo commented 1 month ago

@ceccocats I made PR #7354 I don't know is armbian CI for PR provides images or not. I can share image for SD card that I built earlier( if it allowed here to post links on mega)

SuperKali commented 1 month ago

We can close this issue, the PR was merged on mainline #7354, to report an issue open a new issue, and the maintainer will check it