armbian / build

Armbian Linux build framework generates custom Debian or Ubuntu image for x86, aarch64, riscv64 & armhf
https://www.armbian.com
GNU General Public License v2.0
4.27k stars 2.34k forks source link

customize-image.sh.template: # set static network configuration based on DHCP settings – violation of rfc2131 #796

Closed chymian closed 7 years ago

chymian commented 7 years ago

like in line 154 ff it is tried to make a static ip configuration out of an IP-addr. which is in the DHCP-server IP-pool and so under it's authority and NOT meant to be used in static configurations.

consider the following: the OMV-device got initially an IP-adr. from the server, which does not assign addresses indefinitely per rfc. but the script assigns the IP in a static manor to the OMV-device, which may work, as long as the device is online. if the device is turned off for longer time than the lease-time, the server may assign this address to another participant. turning on the OMV again during that lease-time would end up in having the IP-adr. 2x in the same network and end up in a malfunctioning of the two devices. that's way one never ever configure static addresses out of an DHCP-pool.

ThomasKaiser commented 7 years ago

The customize-image.sh.template is called template for a reason. It's not part of Armbian but was used to create OMV images in a documented way the last months. This ugly hack was needed to get ODROID-C2 up and running with OMV (surviving first reboot without broken networking) as a result of another ugly hack done before (to workaround random MAC address with ODROID-C2 and mainline kernel). The average OMV user fears DHCP anyway and will set up another IP address config via web UI immediately.

Fixed at the same time you reported this here: https://github.com/armbian/build/commit/fcd1ee15c38289f696ace5072c794d633d3c067c (neither know nor care whether this will break next ODROID-C2 OMV build or not)