search

armbian / config

Armbian Linux configuration utility
GNU General Public License v2.0
467 stars 168 forks source link

Add submodule to select APT mirror from URL #135

Closed tparys closed 3 years ago

tparys commented 3 years ago

Possible patch to provide functionality requested in Issue #120.

Considered doing something more complicated given that there are mirrors listed for various regions.

However, there's currently only two unique mirrors, and "https://minio.k-space.ee/armbian/apt" is listed multiple times under "default".

So, doing the stupid simple thing for now.

igorpecovnik commented 3 years ago

However, there's currently only two unique mirrors

That is correct. This is changing - when packages are pushed up, only primary mirrors are enabled until files are not reached around.

Thank you!

igorpecovnik commented 3 years ago

Tested, works.

Optional enhancements:

tparys commented 3 years ago

As a thought, if things are still in flux, would it be better to use the apt mirror transport? And then just add something like this:

deb mirror://apt.example.org/mirror.lst bullseye main

Might be a more standard way of skinning that proverbial cat? I think apt will then auto-select the right mirror?

Failing that, if you have an idea of what the mirrors might look like in the future, might be something better to test with.

tparys commented 3 years ago 
* moving under "personal"

Not sure I follow what you mean here.

tparys commented 3 years ago 
* moving under "personal"

Not sure I follow what you mean here.

Nevermind. I think I see.

igorpecovnik commented 3 years ago

I think apt will then auto-select the right mirror?

Well, we already implemented geo location based mirror selection so client based selector is not needed.

This whole functionality is a backup override if user prefers to fix it or in case system crashes. Hopefully this will not happen often.

tparys commented 3 years ago

Added another commit that should address your requests.

Noticed that https://apt.armbian.com/mirrors has changed. If you need more complicated functionality, let me know and I can take another crack at it?

igorpecovnik commented 3 years ago

If you need more complicated functionality, let me know and I can take another crack at it?

If you wanna play more, check API https://github.com/armbian/dl-router#api

Choosing geolocation/auto, regions and fixed? Like:

  1. Automated
  2. Region 1
  3. Region 2
  4. ...
  5. Fixed 1
  6. Fixed 2

Perhaps this way?

tparys commented 3 years ago

Yeah. The expected interface is clear, but how to tackle it is not.

Ordinarily I'd break it up into a couple of functions, but debian-config-jobs is not set up that way. It's a 1600+ line bash function that looks like it needs some love.

I'll poke at it a bit, and push another commit if if it doesn't get too messy.

I may take a crack at reorganizing that if I get motivated. I've done something similar to generate dialog menus via a directory folder structure, and might be nicer to maintain longer term.

tparys commented 3 years ago

Minor cleanups, which I think does what you've requested given the documentation you pointed at.

I think it's working, but am having some IPv6 issues, so am getting intermittent results.

Let me know if it's working for you.

igorpecovnik commented 3 years ago

Ordinarily I'd break it up into a couple of functions, but debian-config-jobs is not set up that way. It's a 1600+ line bash function that looks like it needs some love.

Agree. This armbian-config is 10+ years code which has origin in my private scripts for setting up some services. Things were just added without any serious RFC. This and lack of proper maintenance is the reasons it has been labelled as beta for years.

If you feel amused by seriously reworking armbian-config - you are more than welcome and we will support best way possible. When things start moving also more random help usually appears ..

Let me know if it's working for you.

It does. I think all mirrors are ipv6 capable, but networking issues - which are outside our control - can appear. We are also working on a script that will regularly check mirror's health and remove/add broken ones as fast as possible.

tparys commented 3 years ago

If you feel amused by seriously reworking armbian-config - you are more than welcome and we will support best way possible. When things start moving also more random help usually appears ..

I'll definitely take a crack at it sometime, but not on this pull request.

Think I'm going to need to do some more reading before I take a crack at a larger piece.

igorpecovnik commented 3 years ago

I'll definitely take a crack at it sometime, but not on this pull request.

Sure, here functionality is covered so I guess we can merge this in.

Think I'm going to need to do some more reading before I take a crack at a larger piece.

Probably best is to make a design together and break into smaller chunks. We use https://armbian.atlassian.net/ for managing / have some control over development. Without access its read only. Send me email for access.