search

armbian / config

Armbian Linux configuration utility
GNU General Public License v2.0
467 stars 168 forks source link

Allow user to specify DNS when setting static IP #143

Closed AristoChen closed 3 years ago

AristoChen commented 3 years ago

Hi,

This PR is for #142, please let me know if I misunderstood anything or did anything wrong, thanks!

btw, I also found there are some other code in this file still using 8.8.8.8 as DNS(line 235, line 413, line 441), is it supposed to be modified as well?

lanefu commented 3 years ago

Hi,

This PR is for #142, please let me know if I misunderstood anything or did anything wrong, thanks!

btw, I also found there are some other code in this file still using 8.8.8.8 as DNS(line 235, line 413, line 441), is it supposed to be modified as well?

Yes looks like should be added for all

AristoChen commented 3 years ago

for function called create_if_config, it does not trigger a dialog for user to type anything, so I directly use dns=$gateway

for function called systemd_ip_editor and ip_editor, use the same way as nm_ip_editor

lanefu commented 3 years ago

@AristoChen sorry for the delay I didn't notice your updates earlier

lanefu commented 3 years ago

tested on buster looks good