Closed seth-hunter closed 1 year ago
What about x86 and situations where we don't have DTB package? Where we use dtb from a kernel. I think media kernel is that case.
I may not fully understand the context, just know that the error here causes problems on systems that do need the dtb package. Doesn’t the if block that I moved the append into cover the scenario you mention in the way that your original change intended?
If we don't check for DTB package existence it assumes it exists and it will fail to download everything where it doesn't (at least the way things are assembled now). In those two cases I have mentioned. How to check if packages exists in most resilient way?
Doesn’t line 504 do this?
You are right. I did the same for u-boot. Any other issue?
I agree that looks cleaner and still resolves the problem I ran into.
Fix #179. The prior if block already checks if the specified version of dtb package exists, so move the variable append to that block instead of performing a second check that doesn't work.