search

armbian / config

Armbian Linux configuration utility
GNU General Public License v2.0
462 stars 163 forks source link

fix bsp Freeze/Unfreeze flakyness #224

Closed alexl83 closed 1 month ago

alexl83 commented 2 months ago

Freeze-Defreeze bsp-cli package based on armbian-bsp-cli-${BOARD}-${BRANCH} makes bsp freezing more consistent as armbian-bsp-cli-${BOARD} is not installed at build-time

alexl83 commented 1 month ago

hi @igorpecovnik - not sure how to request a review - probably not authorized - whenever feasible could you please have a look and consider assigning this PR for review? :)

Thanks my friend! Ale

Tearran commented 1 month ago

@alexl83 just in case you miss the NOTICE: "We are refactoring this tool. Your input & help is more then welcome!" and I personally consider this project deprecated

I invite you to join us on the refactoring @ https://github.com/armbian/configng your input is welcomed there

alexl83 commented 1 month ago

Thank you @Tearran: you're right I missed the notice but noticed the configng repo - should have been paying more attention given this tool is still distributed via repo and included in images, you might consider this small fix - I can close this PR as well with no problem

apologies for this misunderstanding :)

igorpecovnik commented 1 month ago

... ideally fix should be made for both - if this module is already ported to configng.

should have been paying more attention

Yeah. Things are moving lately, thanks to @Tearran ! I hope we will be able to ship both soon. Once there are people that use this tool, then it gets easier.

alexl83 commented 1 month ago

Great news, I'll have a look at configng - what's not clear to me if we want bsp-cli package to be frozen by the "Freeze packages" option - if so, then I'd go with freezing armbian-bsp-cli-${BOARD}-${BRANCH} to avoid confusion

I'm going to check and propose the same solution there, if needed at all :) Thanks guys

Tearran commented 1 month ago

@alexl83 Thank you for your contribution and for acknowledging the oversight. It’s great to see the community taking an active interest in these projects.