search

armbian / configurator

armbian-config drop-in replacement
GNU General Public License v3.0
5 stars 6 forks source link

Bug in command line execution of configurator #9

Closed TheLinuxBug closed 2 years ago

TheLinuxBug commented 2 years ago

root@host:~# configurator docker --help File "/usr/share/armbian/configurator/modules/docker/module.cli", line 17 def list_dirs(from_dir=".", containing_files=[]) -> list: ^ SyntaxError: invalid syntax

Miouyouyou commented 2 years ago

I wonder if this is due to using the wrong Python version. The shebang is wrong on the CLI file, leading to the script being executed with Python 2.x instead of Python 3.x, most of the time. PR #15 should solve this. Give it a try.

TheLinuxBug commented 2 years ago

This looks to be fixed now:

root@rockstorage:~# configurator docker --help Check /usr/share/armbian/configurator/modules/docker/softwares with files ['docker-compose.yml'] Does /usr/share/armbian/configurator/modules/docker/softwares/haproxy/docker-compose.yml exist ? True Does /usr/share/armbian/configurator/modules/docker/softwares/pihole/docker-compose.yml exist ? True Check /opt/armbian/docker with files ['docker-compose.yml'] Does /opt/armbian/docker/haproxy/docker-compose.yml exist ? True usage: module.cli [-h] [--install AVAILABLE_IMAGE [AVAILABLE_IMAGE ...]] [--remove INSTALLED_IMAGE [INSTALLED_IMAGE ...]] [--start INSTALLED_IMAGE [INSTALLED_IMAGE ...]] [--stop INSTALLED_IMAGE [INSTALLED_IMAGE ...]] [--status INSTALLED_IMAGE [INSTALLED_IMAGE ...]] [--service {start,stop,status,enable,disable}]

Armbian docker installation module

optional arguments: -h, --help show this help message and exit --install AVAILABLE_IMAGE [AVAILABLE_IMAGE ...] Add docker installations --remove INSTALLED_IMAGE [INSTALLED_IMAGE ...] Remove installed dockers --start INSTALLED_IMAGE [INSTALLED_IMAGE ...] Start selected installed docker-compose images --stop INSTALLED_IMAGE [INSTALLED_IMAGE ...] Stop selected installed docker-compose images --status INSTALLED_IMAGE [INSTALLED_IMAGE ...] Status of installed dockers --service {start,stop,status,enable,disable} Manage the docker service

AVAILABLE_IMAGE : ['haproxy', 'pihole'] INSTALLED_IMAGE : ['haproxy']