Closed Joshua-Riek closed 2 months ago
How similar are 5 and 5 pro devicetrees? Perhaps it would be cleaner if we include 5 devicetree and make the needed adjustments
Let me take a closer look at the device trees, if we can just include the opi5 device tree that would be great.
Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different.
For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different.
For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
I don't really like current style. Are there any good reason that explains why Xunlong splits them into 3 files?
Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different. For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
I don't really like current style. Are there any good reason that explains why Xunlong splits them into 3 files?
I do not like it either and have found no explanation as to why Xunlong splits them into 3 files. I think the OPI5 device tree should be re-written, but it's not something I have the time for right now.
Hmm it does not look simple and would likely require some time digging through the whole OPI5 Pro device tree since what we have for the OPI5 is quite different. For reference - Orange Pi 5 DTS are split into the following files: https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi https://github.com/armbian/linux-rockchip/blob/rk-5.10-rkr6/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
I don't really like current style. Are there any good reason that explains why Xunlong splits them into 3 files?
I do not like it either and have found no explanation as to why Xunlong splits them into 3 files. I think the OPI5 device tree should be re-written, but it's not something I have the time for right now.
Ok then no problem. I can take a look to refactor opi5 series devicetrees later
can we sqeeze this into upcoming release?
Sorry for delay, I'll fix this shortly, honestly forgot :P
We are all crazy busy. no worries. Thanks!
Failing :(
Oh, there was a typo in the LCD overlay, thanks for catching this in https://github.com/armbian/linux-rockchip/pull/179!
Introduce a device tree for the new Orange Pi 5 Pro.
Build system PR: https://github.com/armbian/build/pull/6506
Cherry Picked from: https://github.com/orangepi-xunlong/linux-orangepi/commit/d910e311b5c923c7cdd85b46fc5965f4a555489e
AR-2144