Add firefly-itx-3588j Device tree on Rk 6.1 rkr1

armbian / linux-rockchip

Improved Rockchip Linux

Other

99 stars 142 forks source link

Add firefly-itx-3588j Device tree on Rk 6.1 rkr1 #188

Closed SeeleVolleri closed 1 month ago

SeeleVolleri commented 2 months ago

oh sorry I forgot adding cooling fan

SeeleVolleri commented 2 months ago

done, squashed

SeeleVolleri commented 2 months ago

done

SeeleVolleri commented 2 months ago

chainsx commented 2 months ago

I suggest integrating the device tree of this device into a single file. Copying the device tree from the BSP directly for submission is in my opinion a downward spiral in overall readability and quality.

SeeleVolleri commented 2 months ago

I'm cleaning up dtsi files now

SeeleVolleri commented 2 months ago

Cleaned up, now building...

amazingfate commented 2 months ago

Makefile change is missing.

SeeleVolleri commented 2 months ago

Thanks for reminding me that!

SeeleVolleri commented 2 months ago

I got a new problem, fixing on that...

[🔨]   Error: arch/arm64/boot/dts/rockchip/rk3588-rk806-single.dtsi:12.26-27 syntax error
[🔨]   FATAL ERROR: Unable to parse input tree
[🔨]   make[3]: *** [scripts/Makefile.lib:422: arch/arm64/boot/dts/rockchip/rk3588-firefly-itx-3588j.dtb] Error 1
[🔨]   make[3]: *** Waiting for unfinished jobs....

SeeleVolleri commented 1 month ago

make ARCH=arm64 dtbs has no errors, I'm going to build armbian tomorrow, my UPS is running out of power. And thanks @chainsx for pointing out build failure because rockchip.h missing pins!

SeeleVolleri commented 1 month ago

I made a very dumb mistake before: Somehow uboot reads rk3588s-roc-pc.dtb and I keep editing rk3588-firefly-itx3588jdts to correct the periphels error. Now it boots flawlessly without any mistake or missing devices, all working! Apologize for verbose pr and commits. Thanks!