armcha / LuseenBottomNavigation

BottomNavigationView Designed according Google guideLine
1.01k stars 180 forks source link

Shadow of bottom bar covers actual content #4

Closed amilcar-andrade closed 8 years ago

amilcar-andrade commented 8 years ago

It seems that the view you are creating with the gradient as a background it is actually cutting the content. In your examples the shadow looks good because you do not have any content and the background is white. I would expect to see something like the attached image where the shadow it is on top of the content.

screenshot_20160329-100021-2

armcha commented 8 years ago

Hi, thanks for issue. With scrolling content it looks good

default

With non scrolling content you can do something like this

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@android:color/white">

    <ImageView
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentBottom="true"
        android:layout_marginBottom="@dimen/bottom_navigation_height"
        android:src="@drawable/adrenalin" />

    <com.luseen.luseenbottomnavigation.BottomNavigation.BottomNavigationView
        android:id="@+id/bottomNavigation"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentBottom="true" />
</RelativeLayout>

Result

2

amilcar-andrade commented 8 years ago

@armcha so did you change something?

armcha commented 8 years ago

@amilcar-andrade soon there will be also available

 bottomNavigationView.disableShadow() 

option

amilcar-andrade commented 8 years ago

Cool, thanks!

armcha commented 8 years ago

@amilcar-andrade can i close issue?