search

armdevvel / mxe-STATIC

MXE (M cross environment) (For ARM32 Windows development)
https://mxe.cc
Other
4 stars 2 forks source link

Allow deprecated GTimeVal type in gdk-pixbuf-animation API. #7

Closed treeswift closed 2 years ago

treeswift commented 2 years ago

GTK3 builds with -Wno-deprecated-declarations. Its dependency, gdk-pixbuf-animation.h, uses deprecated GTimeVal in API. The reason for GTimeVal deprecation is that it's 2038-unsafe. IOW, it wraps around every 68 years. A mere animation glitch as rare as Halley's Comet is probably harmless. Adding a relaxed diagnostic #pragma around the API declarations.

P.S. This is the last fix (out of 3 total) it took me to build GTK3.

pahaze commented 2 years ago

This is absolutely amazing! It took me probably... 50 builds(?) if not more to get a singular working build out, and even then it was very buggy. Is this the only fix needed besides the -lpthread fix?

treeswift commented 2 years ago

There is also glib-compile-resources (which I honestly just hacked, but it needs a proper fix). Issue #6 (btw is "documentation" the correct label? I.e. is reusing the distro resource compiler the recommended solution?)

pahaze commented 2 years ago

For the time being... most likely yeah. It works, soooo... Also didn't mean to put documentation, lol

pahaze commented 2 years ago

Gonna go ahead and merge, we can add whatever else is needed afterwards ; )