search

armedbear / abcl

Armed Bear Common Lisp <git+https://github.com/armedbear/abcl/> <--> <svn+https://abcl.org/svn> Bridge
https://abcl.org#rdfs:seeAlso<https://gitlab.common-lisp.net/abcl/abcl>
Other
288 stars 29 forks source link

[azf-fix-630] fixup for @alejandrozf CLOS propagation on existent instances #633

Closed easye closed 10 months ago

easye commented 10 months ago

Supersedes https://github.com/armedbear/abcl/pull/632.

easye commented 10 months ago

@alejandrozf Thanks for the work, as always. Your work in https://github.com/armedbear/abcl/pull/632 didn't merge cleanly so I had to manually edit things to get this merged. Out of this, I wanted to give you a couple notes that I feel could help improve your contributions to ABCL even more, at least from my perspective. Please feel free to disagree or argue back if you feel otherwise.

  1. When you have a test for fixing something, it helps to place that test in a separate commit the proceeds the patch that fixes it. This way it is easy to set up a "before" and "after" situation if one wants to verify that the patch actually fixes the behavior.

  2. The informal style guideline for commit messages uses the first line of the commit message to summarize the contents of the patch, then followed by a blank line, then as much information, summary and URIs to relevant discussion and context as one feels is necessary to explain the patch.

Thanks as always for the contribution!

alejandrozf commented 10 months ago

Hi @easye

Thanks for the guidelines

They are indeed useful ones

I'll try to follow it for my next contributions :)