search

armgong / rjulia

R package which integrating R and Julia
GNU General Public License v2.0
145 stars 23 forks source link

[wip] String not ascii for 05 #40

Closed phaverty closed 8 years ago

phaverty commented 8 years ago

This should be what is required to switch to String from ASCIIString and UTF8String for julia 0.5. There was one fix for an apparent change in the API for symbols. There are also a few changes in snprintf formatting codes to fix some compile warnings.

This is not backwards compatible. The 0.4 to 0.5 changes are mixed in throughout the code, so I'm not sure how one would use IFDEF blocks to handle 0.4 and 0.5 at the same time.

I believe there is some trouble with libjulia there is a symbol (not used by rjulia) that cannot be found. I think this is a problem with julia itself, but I don't fully understand the issue.

armgong commented 8 years ago

thank you for you work.

I create a branch julia0.5 and merge this pull request , please checkout this branch . there are some different between julia 0.4 and 0.5 C API, so I think we need two branch for them. master for 0.4 release ,which mean stable version , and julia0.5 for future development ,otherwise we will need lot's ugly IFDEFINE in code.

after Julia 0.5 release and stable, we will rename julia0.5 to master branch ,also rename current master to 0.4 and enter maintenance mode .

armgong commented 8 years ago

since julia is 0.x version and api change rapidly , I think we should not support old julia version in master branch, only for current julia release version, old version support in separate branch . for example 0.3 branch for julia 0.3x version ,0.4 branch for julia 0.4x , master for julia 0.5x .

only after 1.0 version ,maybe we need support multi-version julia in master branch。

phaverty commented 8 years ago

Used as basis for julia0.5 branch. Closing.