search

armgong / rjulia

R package which integrating R and Julia
GNU General Public License v2.0
146 stars 23 forks source link

hack jl_is_float{32,64} #51

Closed bbolker closed 7 years ago

bbolker commented 7 years ago

this is a pretty trivial change, but I needed it in order to install successfully (64-bit Ubuntu 14.04, julia 0.5.2, R-devel). Probably needs to be tested on a wider range of platforms!

phaverty commented 7 years ago

Thanks! I will test your branch on RedHat and Mac OS.

Pete

Peter M. Haverty, Ph.D. Genentech, Inc. phaverty@gene.com

On Wed, Jul 19, 2017 at 6:42 AM, Ben Bolker notifications@github.com wrote:

this is a pretty trivial change, but I needed it in order to install successfully (64-bit Ubuntu 14.04, julia 0.5.2, R-devel). Probably needs to be tested on a wider range of platforms!

You can view, comment on, or merge this pull request online at:

https://github.com/armgong/rjulia/pull/51 Commit Summary

  • hack jl_is_float{32,64}

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/armgong/rjulia/pull/51, or mute the thread https://github.com/notifications/unsubscribe-auth/AH02KxEHoGu_ednBPx45b22xc9rPTBW_ks5sPgfBgaJpZM4Ocv2b .

phaverty commented 7 years ago

The unit tests pass using this branch with our 64bit RedHat system and Mac OS 10.12.5, for what that is worth. I'll merge this in the next few days if there aren't any objections.