search

armin-pfaeffle / ap-image-zoom

jQuery plugin for image zoom, based on hammer.js and jquery.mousewheel
MIT License
4 stars 2 forks source link

Double tap to zoom-in/out #3

Open scooterlord opened 8 years ago

scooterlord commented 8 years ago

Hello! Is this still in development? I would love to see some double-tapping for zooming in-out of the image.

armin-pfaeffle commented 8 years ago

Hey! Well, more or less I work on this plugin if I need some changes, but until now there was no need for.

Double-tapping is already implemented. Have a look at the corresponding settings. Is that what you were looking for?

scooterlord commented 8 years ago

Looks like this was it - but would be nice to have mouse double-click also for zooming in and out. Also I just noticed you are using absolute transformations (left, top) instead of css3 transforms (transform:translateX and transform:translateY)- this would drastically increase the performance of the panning!

armin-pfaeffle commented 8 years ago

What exactly do you mean with zooming in and out? What is not possibile with doubleClick option?

No, I'm using transform! Have a look at updateSizeAndPosition. There you can see that if SVGs are used or this.settings.hardwareAcceleration is true (default: true) then CSSs transform is used.

Soon, I will publish a documentation for that plugin!

scooterlord commented 8 years ago

You can use css3 transforms for non-svg elements as well and you should - the performance is a lot better. Instead of using left: value you can use transform:translateX(value).

Concerning double-click, all I meant was to 'fake' double tap with double-click - first double-click zooms in image, second double-click zooms out image.

Yeah, documentation would be nice, your plugin has a lot of potential! Keep up the good work!

armin-pfaeffle commented 8 years ago

My plugin uses transform per default! I know about the performance issue of using left/top. But in some cases it makes sense to use that way (e.g. supporting older IE versions).