search

arminbiere / cadical

CaDiCaL SAT Solver
MIT License
384 stars 134 forks source link

Writing Compressed Files not Thread-Safe #117

Open arminbiere opened 1 month ago

arminbiere commented 1 month ago

As the test case parcompwrite in the thread-safe-compressed-file-writing branch shows, the earlier introduced pipe|open|fork|exec|wait replacement of popen for writing compressed files through a pipe hangs if multiple threads try this. We either need to document it, prevent it through locking, remove the feature, or find a (another) safe replacement.

arminbiere commented 1 month ago

We have some preliminary support for fixing this (third solution) by using '::closefrom'. See the discussion to pull requests #120 and #121.