arminc / terraform-ecs

AWS ECS terraform module
MIT License
804 stars 374 forks source link

Initial Deploy Script Syntax Error #19

Closed weklund closed 3 years ago

weklund commented 6 years ago

I've looked at deploy.sh, I can't seem to find the root of an error I keep getting after cloning master:

./deploy.sh CONTAINER_VERSION=nginx:alpine create

Error parsing parameter 'cli-input-json': Invalid JSON: Expecting value: line 6 column 16 (char 95)
JSON received: {
  "family": "nginx",
  "containerDefinitions": [
    {
      "name": "nginx",
      "image": ,
      "memory": 128,
      "portMappings": [
        {
          "containerPort": 80,
          "protocol": "tcp"
        }
      ]    
    }
  ]
}
sleavitt commented 6 years ago

The issue with that JSON is that there is no valid value for the "image" node. Whatever is generating that JSON is apparently not populating a proper value for "image".

Patrik-Stas commented 4 years ago

I've opened PR to fix this https://github.com/arminc/terraform-ecs/pull/31

arminc commented 3 years ago

Fixed by #31