Configure aws provider from root vars and make repository region-agnostic.

JustinTRoss commented 3 years ago

Define aws region with variable aws_region in ecs.tfvars.
Define aws profile with variable aws_profile in ecs.tfvars.
Change name of ecs_aws_ami variable to aws_ecs_ami in ecs.tfvars for consistency.
Use latest Linux 2 ECS-optimized AMI if none specified (default).
- Accomplishing this via aws_ami datasource.
Replace hardcoded region in user_data.sh with current region from aws_region datasource.
Remove region-specific timezone specification from user_data.sh, which is no longer necessary with Linux 2 AMI.

arminc commented 3 years ago

LGTM, if you can fix the conflicts caused from your past (very appreciated) PR's I can merge this in

JustinTRoss commented 3 years ago

Conflicts resolved.

arminc / terraform-ecs