search

armindarvish / consult-omni

A Powerful Versatile Omni Search inside Emacs
https://github.com/armindarvish/consult-omni/tree/main
165 stars 4 forks source link

fix broken app paths list #22

Closed Dev380 closed 3 months ago

Dev380 commented 3 months ago

The code for detecting app paths on gnu/linux scans this list:

(list consult-omni-apps-xdg-data-home
       consult-omni-apps-xdg-data-dirs
       "/usr/share"
       "/usr/local/share")

However, consult-omni-apps-xdg-data-dirs is a list itself and not a string, so this will create a list with three strings and one list of strings, which breaks the code and doesn't let any application in consult-omni-apps-xdg-data-dirs be launched. To fix this, the three strings must be appended to the consult-omni-apps-xdg-data-dirs string.

armindarvish commented 3 months ago

@Dev380 Thanks for reporting the issue and the PR. I went ahead and resolved the problem in PR #23 (as I was fixing some other issues as well).

For future reference, follow the instructions in the README here: contributions The PR should merge with the develop branch (and not the main branch) just in case we want to test the code for some time before merging with main.