search

armindarvish / consult-web

Powerful Web and Omni Search inside Emacs
https://github.com/armindarvish/consult-web
86 stars 6 forks source link

is youtube source broken? #25

Closed agzam closed 5 months ago

agzam commented 5 months ago

Sorry, I'm a bit late to the party. I finally get to try out this thing. I'm not sure if something is missing on my setup or if this is a legit bug. I couldn't figure out how to get YouTube search. I've got the API key, etc., and consult-web-google, that requires similar setup worked right away.

I haven't tried to debug this yet, just reporting it in case someone comes across it.

armindarvish commented 5 months ago

not sure, what the issue is. The only thin I noticed was that youtube was using consult-web-google-customsearch-key, which should have worked anyway but if one wants to use different accounts, it would cause confusion. I fixed that now. Google and Youtube can use separate keys.

@agzam Can you set consult-web-log-level to debug and check the contents of the buffer *consult-web-log*. Note the space in the buffer name. it's a hidden buffer. (or check the variable consult-web-log-buffer-name to see the name of the log buffer if you have set that) and see if there's any useful information in there. You can also check the url-retrieve buffers. Look for a hidden buffer called *http www.googleapis...*

If you copy the content of either of those buffers here, make sure to remove the secret keys if any

avishefi commented 5 months ago

check-parens on consult-web-youtube.el shows that the last commit removed an extra parenthesis.

armindarvish commented 5 months ago

@avishefi Oops! I missed a parenthesis. I fixed it now!

agzam commented 5 months ago

Thank you for fixing it. It works now.

armindarvish commented 5 months ago

@agzam By the way, I am working on introducing async sources, and etc. in async branch. This is almost a complete redesign of the whole package. So if you are just starting to test things out, you may want to look at that branch instead of develop.

For example, I have added support for "invidious" there, so you won't need YouTube API!

agzam commented 5 months ago

That's cool. I'm still very new to the package and its features. At this point, I'm not even an early tester; I'm still a mere consumer. I want to find some bandwidth to explore it better and add some custom search sources. For now, I'm only using basic features.

armindarvish commented 5 months ago

@agzam I would suggest against working too much on new sources right now because it will all change when I switch to the new async approach.

agzam commented 5 months ago

Eh, what’s the worst that could happen? I already adore you for getting this started. Sure, I might be momentarily hate you if it breaks, but I’ll quickly go back to loving you once it’s up and running again.