config.py references non-namespaced sip module

arminstraub / krop

A simple graphical tool to crop the pages of PDF files, written in Python/Qt

http://arminstraub.com/software/krop

GNU General Public License v3.0

116 stars 16 forks source link

config.py references non-namespaced sip module #23

Closed rdieter closed 4 years ago

rdieter commented 5 years ago

config.py curently includes code: krop/config.py: import sip krop/config.py:sip.setapi('QString', 2) krop/config.py:sip.setapi('QVariant', 2)

Not sure it's purpose, but recent sip/PyQt5 releases use a name-spaced PyQt5.sip module instead. So either drop this or switch to PyQt5.sip (depends if the setapi calls are really needed anymore or not)

arminstraub commented 4 years ago

Thank you! This should be fixed now on github and will be included in the next release. The reason for that code is that in python2 (I still have an old Ubuntu 14.04 in service...) needs that call in order to use the modern PyQt API.