search

arminstraub / krop

A simple graphical tool to crop the pages of PDF files, written in Python/Qt
http://arminstraub.com/software/krop
GNU General Public License v3.0
122 stars 13 forks source link

PyPDF2 usage: New syntax / deprecations and the dependency #35

Closed MartinThoma closed 1 year ago

MartinThoma commented 2 years ago

Hi!

I've noticed that krop uses PyPDF2. Is there a reason for not putting it in the setup.py as a dependency?

PyPDF2 has changed a lot since April. We try hard not to break stuff (see deprecation process), but we also want to move forward. As we modernized the API, a lot of the names changed. It's mostly switching from camelCase to snake_case, but see CHANGELOG "deprecation" for details.

MartinThoma commented 2 years ago

Especially under 1.28.0: https://pypdf2.readthedocs.io/en/latest/meta/CHANGELOG.html#id40

MartinThoma commented 1 year ago

I became the maintainer of pypdf as well and migrated the PyPDF2 project into pypdf (now all lowercase).

However, it seems to me that krop is dead.

arminstraub commented 1 year ago

Thank you, Martin! It is fantastic to see pypdf so alive again :) My apologies for the horribly long silence due to too little time.

I have just added support for pypdf and the new naming scheme. pyPdf and PyPDF2 are also still supported. (The only non-supported option is PyPDF2 with the new naming scheme, which I believe only existed for a brief moment of time; if anybody desperately needs that supported as well, this could certainly be done easily.)

I will soon adjust the documentation and installation guidelines.

PS: I'll have to think about the dependency question. I'm leaning against it since krop can run (but not crop) without pypdf. Now pikepdf is an alternative option as well and more might be added. (In the past, I liked having the option of having the various needed Python packages installable from a variety of sources as well as installable after the fact.)