search

armory-plugins / armory-observability-plugin

Spinnaker plugin for enabling, configuring, and customizing observability features.
Apache License 2.0
20 stars 16 forks source link

Tag keys are not always following snakeCase #63

Closed christosarvanitis closed 8 months ago

christosarvanitis commented 8 months ago

Prometheus server expect to have the tag keys in snakeCase otherwise are dropped during scrape. Specifically for CloudFoundry okhttp metrics we have seen that some tag keys are not following the snakeCase, ie:

# HELP cf_okhttp_requests_seconds  
# TYPE cf_okhttp_requests_seconds summary
cf_okhttp_requests_seconds_count{host="host",lib="aop",libVer="v1.4.2-SNAPSHOT",method="POST",spinSvc="clouddriver",status="IO_ERROR",target.host="host",target.port="443",target.scheme="https",uri="none",} 21.0
cf_okhttp_requests_seconds_sum{host="host",lib="aop",libVer="v1.4.2-SNAPSHOT",method="POST",spinSvc="clouddriver",status="IO_ERROR",target.host="host",target.port="443",target.scheme="https",uri="none",} 6.755297792
# HELP cf_okhttp_requests_seconds_max  
# TYPE cf_okhttp_requests_seconds_max gauge
cf_okhttp_requests_seconds_max{host="host,lib="aop",libVer="v1.4.2-SNAPSHOT",method="POST",spinSvc="clouddriver",status="IO_ERROR",target.host="host",target.port="443",target.scheme="https",uri="none",} 0.981907154