search

armory-plugins / armory-observability-plugin

Spinnaker plugin for enabling, configuring, and customizing observability features.
Apache License 2.0
20 stars 16 forks source link

fix(tags-service) adding new MAIN_APPLICATION_CLASS tags #65

Closed shlomodaari closed 7 months ago

christosarvanitis commented 7 months ago

This will fail in prometheus scraping as it is not a valid snakeCase for prometheus. - in labels is prohibited.

You can test it using '''echo some_metric{main-application-class="label-value"}|promtool check metrics'''