fix(secrets): Delete secrets handler to avoid double attempts to decrypt secrets.

armory / dinghy

Pipelines as code for Spinnaker

Apache License 2.0

31 stars 12 forks source link

fix(secrets): Delete secrets handler to avoid double attempts to decrypt secrets. #163

Closed sergio-quintero closed 2 years ago

sergio-quintero commented 2 years ago

go-yaml-tools library already resolves secrets in the yml config files, including vault (See armory/go-yaml-tools#26 and armory/go-yaml-tools#30).

initializer.go was already loading the configuration with resolved secrets before using the handler.

When a secret had an exclamation point "!", since the secret has already resolved, dinghy threw an error complaining the engine was not registered when in fact dinghy didn't need to resolve the secret anymore.

coveralls commented 2 years ago

Coverage decreased (-0.09%) to 53.741% when pulling a000a14852f141bacd4300429550d5da14f9f344 on fix/secrets_with_exclamation into 4a434b9d0389064e34e9455b5a67c84f3b0ddb6d on master.