armory / dinghy

Pipelines as code for Spinnaker
Apache License 2.0
31 stars 12 forks source link

fix(settings): inconsistency between JSON and YAML property name #172

Closed kkotula closed 1 year ago

kkotula commented 1 year ago

As explained in the PR name - there was a small discrepancy between the name of the property in JSON and YAML files.

armory-jenkins commented 1 year ago

The title of this Pull Request needs to be changed to match the format:

<type>(<scope>): <subject>

See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions

Some common examples are:

feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense
coveralls commented 1 year ago

Coverage Status

Coverage: 54.968%. Remained the same when pulling 69b9d27752361850e3346e0a8a6fbf21acf95588 on fix(settings)_update_inconsistent_settgins_properties into fbbffa3e010ee2a4b9c8b9dc914e7cc8c3e43b15 on master.