fix(config): changed two feature flags types from boolean to string.

armory / dinghy

Pipelines as code for Spinnaker

Apache License 2.0

31 stars 11 forks source link

fix(config): changed two feature flags types from boolean to string. #184

Closed kkotula closed 9 months ago

kkotula commented 9 months ago

When merging two configurations - the default one defined in the application’s code and the user-defined one - if a feature flag is set to false in the user config but set to true in the default config, the default value will take precedence over the user-defined value. In such case, it is impossible to disable the feature.

coveralls commented 9 months ago

coverage: 54.625%. remained the same when pulling e93a9892f68c7d09a38d81fa7858a14b20338737 on fix(config)/unoverridable_feature_flags into 1d5ba8c84486e9f2a919fba09085af78e6cad270 on master.