Closed mflis closed 2 years ago
Looks good, I'm going to do some testing to see if this fix works
Built this locally from the fix branch, can confirm it's working correctly on our AKS v1.23.5 cluster. Thanks @mflis !
Build failed on "Login to docker registry" as my fork doesn't have the required secrets. How can we proceed with this MR?
It's also working for me thank you @mflis, Let me see what we can do to get this merge
I'm going to merge this on the following criteria:
If we have issues w/ the builds on master we can revert and/or review to resolve the behavior. Thanks for the contribution @mflis !
This PR wasn't build and push to docker registry
During the dependencies upgrades, object type of Secrets changed from v1.Secret to Unstructured. We need to cast it to make secrets.go TransformManifests method work again.
Related: https://github.com/armory/spinnaker-operator/issues/245#issuecomment-1180613717