Fix transforming k8s secrets

armory / spinnaker-operator

Open Source Spinnaker Kubernetes Operator source code

Apache License 2.0

187 stars 70 forks source link

Fix transforming k8s secrets #262

Closed mflis closed 2 years ago

mflis commented 2 years ago

During the dependencies upgrades, object type of Secrets changed from v1.Secret to Unstructured. We need to cast it to make secrets.go TransformManifests method work again.

ichi0915 commented 2 years ago

Looks good, I'm going to do some testing to see if this fix works

andrijaperovic commented 2 years ago

Built this locally from the fix branch, can confirm it's working correctly on our AKS v1.23.5 cluster. Thanks @mflis !

mflis commented 2 years ago

Build failed on "Login to docker registry" as my fork doesn't have the required secrets. How can we proceed with this MR?

ichi0915 commented 2 years ago

It's also working for me thank you @mflis, Let me see what we can do to get this merge

dogonthehorizon commented 2 years ago

I'm going to merge this on the following criteria:

Approvals from the community
Build & unit tests are passing
The error is related to credentials sharing across orgs (e.g. this PR from a fork can't read our docker creds)

If we have issues w/ the builds on master we can revert and/or review to resolve the behavior. Thanks for the contribution @mflis !

ElevateTechUser commented 1 year ago

This PR wasn't build and push to docker registry